Repository navigation
Unified: Use getAnArgument() to check argument of a MaD token - #22956
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change adds multi-argument receiver matching in the legacy MaD interpreter and includes regression models, tests, and expected results, with no active review issues identified.
No open issues 🎉
What changed in this PR
Updates Unified’s legacy MaD interpreter to recognize receiver tokens when self appears alongside positional arguments, such as Argument[self,0] and Parameter[self,0].
Changes:
- Matches
ArgumentandParametertokens by name and individual arguments. - Preserves receiver handling for multi-argument tokens.
- Adds Swift MaD regression models, test cases, and expected results.
| File | Description |
|---|---|
unified/ql/test/library-tests/mad/test.swift |
Adds Swift source and sink cases using shorthand MaD tokens. |
unified/ql/test/library-tests/mad/test.ext.yml |
Defines models with combined receiver and positional-argument tokens. |
unified/ql/test/library-tests/mad/test.expected |
Records the expected receiver and explicit-argument results. |
unified/ql/lib/codeql/unified/internal/mad/LegacyMaD.qll |
Supports receiver matching within multi-argument MaD tokens. |
Review effort: Lite (auto)
aschackmull
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writing
token = "Argument[self]"fails to work for tokens likeArgument[self,0]