Skip to content

Use patched latest fmt and rules_dotnet modules - #22954

Draft
jketema wants to merge 1 commit into
mainfrom
copilot/patch-latest-bazel-deps
Draft

jketema wants to merge 1 commit into
mainfrom
copilot/patch-latest-bazel-deps

Conversation

@jketema

@jketema jketema commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add and use patched CodeQL registry versions for fmt 12.2.0 and rules_dotnet 0.22.2.
  • Preserve the fmt Windows FMT_UNICODE=0 workaround, the rules_dotnet NuGet archive patch, and the existing rules_shell 0.6.1 dependency declaration.
  • Update the .NET SDK to 10.0.201 in the root module and both toolchains in the new patched rules_dotnet module.

Validation

  • Registry metadata generated with misc/bazel/registry/fix.py; overlay and patch hashes verified.
  • rules_dotnet patches apply to the 0.22.2 release archive; changed Bazel files pass buildifier.
  • Local Bazel module resolution was blocked by a Java TLS certificate error fetching bcr.bazel.build.

Copilot AI auto review requested due to automatic review settings October 30, 2026 10:27
@jketema
jketema requested review from a team as code owners October 30, 2026 10:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Active findings remain, including a moderate Windows build-regression risk from removing the prior MSVC workaround and a typo in a new comment.

2 open issues
What changed in this PR

Updates CodeQL’s Bazel dependencies to patched releases of fmt 12.2.0 and rules_dotnet 0.22.2, while retaining the .NET SDK pin at 10.0.100.

Changes:

  • Upgrades root dependencies to fmt 12.2.0-codeql.1 and rules_dotnet 0.22.2-codeql.1.
  • Adds registry metadata, source definitions, overlays, and integrity information for both modules.
  • Adds rules_dotnet patches for module versioning and NuGet archive behavior.
  • Validation confirmed metadata hashes, patch application, and buildifier formatting; Bazel resolution remains blocked by TLS certificate validation.
File Description
MODULE.bazel Selects the updated fmt and rules_dotnet modules.
misc/​bazel/​registry/​modules/​rules_dotnet/​metadata.json Registers the new rules_dotnet version.
misc/​bazel/​registry/​modules/​rules_dotnet/​0.22.2-codeql.1/​source.json Defines the release archive, integrity hash, and patches.
misc/​bazel/​registry/​modules/​rules_dotnet/​0.22.2-codeql.1/​patches/​revert_additional_files_in_nuget_archive.patch Restores the desired NuGet archive behavior.
misc/​bazel/​registry/​modules/​rules_dotnet/​0.22.2-codeql.1/​patches/​module_dot_bazel_version.patch Sets the patched module version.
misc/​bazel/​registry/​modules/​rules_dotnet/​0.22.2-codeql.1/​MODULE.bazel Configures the pinned .NET SDK and module dependencies. Review note: the comment contains the typo buit, which should be built.
misc/​bazel/​registry/​modules/​fmt/​metadata.json Registers the new fmt version.
misc/​bazel/​registry/​modules/​fmt/​12.2.0-codeql.1/​source.json Defines the fmt archive, overlays, and integrity hashes.
misc/​bazel/​registry/​modules/​fmt/​12.2.0-codeql.1/​overlay/​MODULE.bazel Provides patched module metadata and dependencies.
misc/​bazel/​registry/​modules/​fmt/​12.2.0-codeql.1/​overlay/​BUILD.bazel Defines the fmt Bazel target, licensing, and package metadata. Review note: preserve the MSVC FMT_UNICODE=0 define from the prior overlay unless the upgrade has a verified fix for the known Windows UTF-8 build failure.
misc/​bazel/​registry/​modules/​fmt/​12.2.0-codeql.1/​MODULE.bazel Provides the versioned fmt module definition.

This pull request requires changes.

Review effort: Lite (auto)

Comment thread misc/bazel/registry/modules/fmt/12.2.0-codeql.1/overlay/BUILD.bazel Outdated
@jketema
jketema marked this pull request as draft October 30, 2026 10:35
Add and use patched registry versions for fmt 12.2.0 and rules_dotnet 0.22.2, preserving the Windows Unicode workaround, NuGet archive patch, and rules_shell declaration. Update the root and module .NET SDK toolchains to 10.0.201.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jketema
jketema force-pushed the copilot/patch-latest-bazel-deps branch from bf55260 to d048fc9 Compare October 30, 2026 13:17

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants