Skip to content

Set up Python 3.12 for Swift formatting - #22907

Merged
jketema merged 1 commit into
mainfrom
copilot/fix-swift-python312
Oct 27, 2026
Merged

jketema merged 1 commit into
mainfrom
copilot/fix-swift-python312

Conversation

@jketema

@jketema jketema commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

The Swift clang-format job runs pre-commit hooks that require Python 3.12, but ubuntu-latest does not guarantee that interpreter is installed. Set up Python 3.12 before invoking pre-commit, matching the existing Python tooling workflow.

See failure here: https://github.com/github/codeql/actions/runs/40535322333/job/122298888816

The clang-format pre-commit job uses the repository's Python 3.12 hook environment, so install that interpreter before running pre-commit.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jketema
jketema marked this pull request as ready for review October 27, 2026 16:31
@jketema
jketema requested a review from a team as a code owner October 27, 2026 16:31
Copilot AI max review requested due to automatic review settings October 27, 2026 16:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrowly scoped workflow change supplies the required interpreter before pre-commit runs, with no blocking issues identified.

No open issues 🎉

What changed in this PR

Ensures the Swift formatting job has Python 3.12 available before running pre-commit, matching the existing Python tooling workflow.

Changes:

  • Add actions/setup-python@v5, configured for Python 3.12, before the pre-commit step.
File Description
.github/​workflows/​swift.yml Provision Python 3.12 for the formatting hooks.

Review effort: Max

@jketema
jketema merged commit fd2bfc8 into main Oct 27, 2026
13 checks passed
@jketema
jketema deleted the copilot/fix-swift-python312 branch October 27, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants