Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are limited to established optimizer annotations, preserve predicate logic, and have no identified blocking issues.
No open issues 🎉
What changed in this PR
Disables dynamic join ordering for seven shared dataflow and range-analysis predicates to avoid poor runtime join plans when the feature is enabled.
Changes:
- Adds
pragma[no_dynamic_join_order]to five dataflow predicates and two range-analysis predicates. - Preserves predicate logic, interfaces, and default compilation behavior.
| File | Description |
|---|---|
shared/rangeanalysis/codeql/rangeanalysis/RangeAnalysis.qll |
Adds the pragma to boundedSsa and initialBounded. |
shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll |
Adds the pragma to three shared dataflow predicates. |
shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll |
Adds the pragma to flowIntoCallApValid and revFlowIn. |
Review effort: Max
aschackmull
previously approved these changes
Oct 26, 2026
kaspersv
force-pushed
the
kaspersv/disable-rtjo-for-select-preds-shared
branch
from
October 26, 2026 12:16
35f6819 to
6fc8b35
Compare
Contributor
Author
|
Fixed QL formatting and rebased on |
aschackmull
approved these changes
Oct 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are working on a new dynamic join orderer for CodeQL that join orders predicates at evaluation-time using run-time cardinality information instead of relying on a statically chosen join order decided at compilation-time. At the moment a couple of predicates in shared libraries are join ordered badly by the dynamic join orderer. This PR disables dynamic join ordering for the affected predicates.
Dynamic join ordering is still disabled by default during compilation and evaluation and the
no_dynamic_join_orderpragma has no effect on compilation when dynamic join ordering is not explicitly enabled during compilation.