Skip to content

C#: Add some more logging to the Dependency Manager. #22889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
michaelnebel wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

C#: Add some more logging to the Dependency Manager. #22889

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02cf0c6
C#: Uncondionally log the number of Restore Nuget Dlls using nuget.ex…
michaelnebel Oct 26, 2026
78e0762
C#: Add some logging related to project file content.
michaelnebel Oct 26, 2026
6873583
C#: Adjust logging messages and add a bit more context.
michaelnebel Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/FileContent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,14 @@ private void DoInitialize()
logger.LogDebug($"Failed to read file {file}, exception: {ex}");
}
}

logger.LogInfo("Finished reading project files.");
logger.LogInfo($"Legacy project structure usage detected: {isLegacyProjectStructureUsed}");
logger.LogInfo($"ASP.NET usage detected: {useAspNetCoreDlls}");
logger.LogInfo($"New project structure usage detected: {isNewProjectStructureUsed}");
logger.LogInfo($"Windows Forms usage detected: {useWindowsForms}");
logger.LogInfo($"WPF usage detected: {useWpf}");
logger.LogInfo($"Implicit usings enabled: {useImplicitUsings}");
}

[GeneratedRegex("(?<!<!--.*)<PackageReference.*\\sInclude=\"(.*?)\".*/?>", RegexOptions.IgnoreCase | RegexOptions.Compiled | RegexOptions.Singleline)]
Expand Down
14 changes: 10 additions & 4 deletions csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/NugetPackageRestorer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,9 @@ public HashSet<AssemblyLookupLocation> Restore()
.Where(path => IsPathInSubfolder(path, legacyPackageDirectory.DirInfo.FullName, "tools"))
.ToList();

if (nugetPackageDllPaths.Count > 0)
{
logger.LogInfo($"Restored {nugetPackageDllPaths.Count} NuGet DLLs.");
}

logger.LogInfo($"Restored {nugetPackageDllPaths.Count} NuGet DLLs from packages.config files using the NuGet CLI.");

if (excludedPaths.Count > 0)
{
logger.LogInfo($"Excluding {excludedPaths.Count} NuGet DLLs.");
Expand All @@ -163,6 +162,13 @@ public HashSet<AssemblyLookupLocation> Restore()
}

nugetPackageDllPaths.ExceptWith(excludedPaths);

logger.LogInfo($"Using {nugetPackageDllPaths.Count} DLLs as dependency candidates from NuGet packages restored via the NuGet CLI based on packages.config files.");
foreach (var path in nugetPackageDllPaths)
{
logger.LogDebug($"Using NuGet DLL as dependency candidate: {path}");
}

assemblyLookupLocations.UnionWith(nugetPackageDllPaths.Select(p => new AssemblyLookupLocation(p)));
}
catch (Exception exc)
Expand Down
Loading