Repository navigation
Conversation
GitHub resolves a renamed repo's old name to the renamed repo, so syncing a stale name undid the rename. Such a repo is now skipped before any plugin runs, unless the config asks for the rename.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A renamed repo's old name still resolves to the repo on GitHub, so syncing a stale name (a removed
old-name.ymlin a push, or a name listed before a rename during a full sync) sentname: old-nameback and undid the rename. A repo whose live name differs from the requested one is now skipped unless the config asks for the rename (repository.name, or theoldnameset byBLOCK_REPO_RENAME_BY_HUMAN). Closes #1123.For reviewers: this overlaps with #1136 and is deliberately smaller (two guards, no new feature). The guard sits in the repository plugin as well as in
updateRepos, so it also holds whenarchiveis indisable_plugins, the case where #1136 still renames back. Not covered: in a full sync where the repository plugin does not run for a repo, child plugins can still apply the old name's config through the redirect; closing that needs one extra GET per repo.