Repository navigation
fix: skip a new dry run while one is running for the same commit - #1140
Closed
TovaBecker wants to merge 2 commits into
Closed
TovaBecker wants to merge 2 commits into
TovaBecker wants to merge 2 commits into
Conversation
When a PR was opened within seconds of the push, check_suite.requested and pull_request.opened both started a dry run, so the PR got two identical comments (github-community-projects#1139). A new run now waits its turn: it is skipped while a Safe-setting validator check run for the commit is queued or in progress, and a re-run after it finishes still works.
The first version skipped any trigger while a run was active, so a run that never finished blocked the commit for good, a same-named check from another app blocked ours, and a failed lookup stopped the dry run. Now only the two racing events skip when this app already has a run on the commit, reopen and re-run always start a new one, and a failed lookup starts the run anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
check_suite.requestedandpull_request.openedboth start a dry run on the same commit, so the PR gets two identical comments (Opening a PR right after pushing runs the dry run twice and posts two comments #1139).Approach
createCheckRunskips when a "Safe-setting validator" check run for the same commit is queued or in progress.Validation
test/unit/index-check-run.test.js. Unit tests: 1019 passed. Integration tests: 107 passed. No newstandardfindings.Closes #1139
🤖 Generated with Claude Code