Repository navigation
github: detect GitHub Proxima hosts - #2498
Merged
Merged
Conversation
GitHub Enterprise with Data Residency (aka Proxima) has is a cloud-native offering of GHE, hosted in Azure. All Proxima instances exist as a subdomain of *.ghe.com, so let's ensure our host detection can pick these up to avoid an expensive network probe. Proxima also has some special behaviour and differences from GHES and DotCom. One difference is that the /meta API endpoint requires authentication, so it cannot be used to query what authentication modes are available; the catch-22 situation! Instead, we specify the set of authentication modes that Proxima hosts can support as PAT & OAuth. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
Contributor
|
Hmm. No idea what's going on with CI: |
GitHub.com and Proxima both have their API endpoints at the api.
subdomain, rather than GHES which has an /api/v{version} route.
Update our logic for computing the API request URLs to also handle
GitHub Proxima like we do for DotCom.
Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
Contributor
Author
|
Thanks for the review @dscho, but I realised I missed also updating the API request URL logic for Proxima. Could you please also look at the new commit I just pushed please? |
dscho
approved these changes
Nov 9, 2026
dscho
left a comment
dscho
left a comment
Contributor
There was a problem hiding this comment.
The additional commit also looks correct to me, but I have to lament that it is necessary: a more consistent design of GHES/Proxima's workings would have been appreciated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Enterprise with Data Residency (aka Proxima) has is a cloud-native offering of GHE, hosted in Azure.
All Proxima instances exist as a subdomain of
*.ghe.com, so let's ensure our host detection can pick these up to avoid an expensive network probe.Proxima also has some special behaviour and differences from GHES and DotCom. One difference is that the
/metaAPI endpoint requires authentication, so it cannot be used to query what authentication modes are available; the catch-22 situation!Today, GCM will attempt and fail to query the meta endpoint with a warning message like:
warning: Failed to query 'https://foo.ghe.com/' for supported authentication schemes.Instead, we specify the set of authentication modes that Proxima hosts can support as PAT & OAuth.
We also update the way we compute an API endpoint, since Proxima is more like Dotcom than it is GHES. The former has the API endpoint sit off of an
apisubdomain, whereas the latter uses an/api/v{version}route.