Skip to content

Rename CLI option --reverse to --rotate - #167

Open
hippi345 wants to merge 2 commits into
git-bahn:masterfrom
hippi345:cursor/rename-reverse-to-rotate-fdb4
Open

hippi345 wants to merge 2 commits into
git-bahn:masterfrom
hippi345:cursor/rename-reverse-to-rotate-fdb4

Conversation

@hippi345

Copy link
Copy Markdown

--reverse rotates the graph 180 degrees, so this renames it to --rotate. -r still works.

  • --rotate is now the documented flag
  • --reverse stays as a hidden alias so existing scripts keep working
  • Adds CLI parsing tests for --rotate, -r, --reverse and the help text
  • Updates CHANGELOG.md and docs/manual.md

cargo fmt, cargo clippy --all --all-targets -- --deny warnings and cargo test --all all pass.

Closes #133

Keep --reverse as a hidden clap alias for backward compatibility.
Add CLI parsing tests and update changelog and manual.
Comment thread src/main.rs
}

fn match_args() -> ArgMatches {
fn build_cli() -> Command {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch making it testable by adding a layer of indirection

Comment thread CHANGELOG.md

### Changed

- Renamed CLI option `--reverse` to `--rotate` (`-r`). `--reverse` remains available as a hidden alias.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking, but please keep two blank lines between releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rename --reverse to --rotate

2 participants