Repository navigation
Conversation
Contributor
size-limit report 📦Compared: e4f8349 (PR test merge using develop at d5cdfe8) Against: dd9903c (develop) · base run #64617
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 4 not successful, 25 successful. See the run.
Successful checks
|
logaretm
force-pushed
the
awad/runtime-tunnel-cloudflare
branch
from
November 2, 2026 21:29
29b761b to
0fa5a24
Compare
logaretm
force-pushed
the
awad/runtime-tunnel-cloudflare
branch
2 times, most recently
from
November 3, 2026 04:10
79c5b03 to
ee6cc70
Compare
logaretm
force-pushed
the
awad/runtime-tunnel-cloudflare
branch
from
November 3, 2026 04:21
ee6cc70 to
dcc387e
Compare
logaretm
force-pushed
the
awad/runtime-tunnel-cloudflare
branch
from
November 3, 2026 04:28
dcc387e to
735789f
Compare
logaretm
force-pushed
the
awad/runtime-tunnel-cloudflare
branch
3 times, most recently
from
November 3, 2026 04:50
dc67ef5 to
02913e0
Compare
logaretm
marked this pull request as ready for review
November 3, 2026 04:56
logaretm
requested review from
isaacs,
mydea,
nicohrubec and
s1gr1d
and removed request for
a team
November 3, 2026 04:56
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 02913e0. Configure here.
| }; | ||
| nitroApp.hooks.hook('error', sentryCaptureErrorHook); | ||
|
|
||
| return; |
There was a problem hiding this comment.
Nitro v3 path skips tracing tags
Medium Severity
The Nitro v3 branch wraps fetch and hooks error, then returns before registering render:html. Cloudflare setups rely on this plugin for that hook, so Nuxt 5 apps will not get Sentry tracing meta tags and distributed tracing from server to client will break.
Reviewed by Cursor Bugbot for commit 02913e0. Configure here.
| const traceDataMap = new WeakMap<object, ReturnType<typeof getTraceData>>(); | ||
|
|
||
| // Nitro v3 (Nuxt 5) has no `localFetch`. It hands the Worker's own request to `fetch`, with `ctx` on it. | ||
| const nitroV3App = nitroApp as unknown as { localFetch?: unknown; fetch?: (request: Request) => Promise<Response> }; |
There was a problem hiding this comment.
Unguarded double-cast in Nitro v3
Low Severity
A new as unknown as double-cast widens nitroApp to a structural fetch shape. The nearby comment explains the Nitro v3 runtime, not why a safer type is impossible. SDK source requires that justification on each double-cast.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 02913e0. Configure here.
The Cloudflare request wrapper answers tunnel requests before the Worker's handler. Nuxt's Cloudflare plugin passes the request with its body, and Astro wraps Pages builds with `withSentry` like Workers builds.
logaretm
force-pushed
the
awad/runtime-tunnel-cloudflare
branch
from
November 3, 2026 05:37
02913e0 to
d0f5ad8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the tunnel handling logic to our CF workers wrapper, and re-wires astro and other CF capable frameworks.