Repository navigation
ref(react-router): Reuse shared glob helper - #25982
Closed
nicohrubec wants to merge 1 commit into
Closed
nicohrubec wants to merge 1 commit into
nicohrubec wants to merge 1 commit into
Conversation
Co-Authored-By: GPT-6 <codex@openai.com>
nicohrubec
changed the title
Member
|
@nicohrubec there were some competing prs, I moved all of it into #26014 |
chargome
added a commit
that referenced
this pull request
Nov 3, 2026
…router (#26014) **Why:** `npm audit` flags `glob@13` and `minimatch@10` in `@sentry/bundler-plugins` and `@sentry/react-router`. Only glob 14 fixes this. This PR takes over #25981 (@renantatsuo) and #25982 (@nicohrubec) with their commits kept, and adds two fixes on top: - React Router now uses `globFiles` from the bundler plugins instead of its own `glob` dependency. - The default `filesToDeleteAfterUpload` pattern used the raw build directory path. On Windows that contains backslashes, which glob treats as escapes, so source maps were never deleted after upload. The path is now converted to forward slashes. The `browser-integration-tests` dev dependency is bumped as well. glob 13 stays in the lockfile through `nx`, `rimraf` and `@vercel/nft`, which are all dev-only. **How to review:** The bump and `globFiles` commits are unchanged from the original PRs. Look at the forward-slash fix in `handleOnBuildEnd.ts` and the new `glob.test.ts` case that runs the upload patterns against the new minimatch 11 matcher. Closes #25969 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: renantatsuo <tatsuorenan@gmail.com> Co-authored-by: Nicolas Hrubec <nico.hrubec@sentry.io> Co-authored-by: GPT-6 <codex@openai.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: React Router already depends on the bundler plugins, whose shared
globFileshelper provides the same matching options. Reusing it removes React Router's directglobdependency while preserving cleanup behavior.How to review: The source map E2E test now verifies that uploaded client maps are deleted and server maps outside the configured pattern remain. Validation passed: development build, React Router lint/type checks and 315 tests, 46 Nuxt deletion/hook tests, 14 helper tests, and the React Router source map E2E test. Repository-wide lint and packaging encounter unrelated Ember issues.