Repository navigation
Drop the always true defined(SIZEOF_TIME_T) from the binary timestamp decoder - #765
Merged
Merged
Conversation
Ruby's configure always defines it.
Contributor
Author
|
Thanks for the merging so fast :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A one-line follow-up to #760, which I pushed a few minutes after you merged it, so it never made it in.
pg_bin_dec_timestampstill guards its fast path withdefined(SIZEOF_TIME_T) && SIZEOF_TIME_T >= 8, but Ruby's configure always definesSIZEOF_TIME_Tinruby/config.h(andwin32/Makefile.subdoes the same on mswin). Even where it didn't, an undefined identifier evaluates to 0 in#if, soSIZEOF_TIME_T >= 8alone already keeps 32-bittime_tbuilds on theTime.atpath.No behavior change:
pg_binary_decoder.obuilds to identical__textand__cstringsections on master and on this branch (Ruby 4.0.9, arm64-darwin).Would you rather take it as its own PR, or should I fold it into the next cleanup that touches this decoder?
🤖 Generated with Claude Code, but prompted, read, and verified by @czj, a caring human :)