Repository navigation
Document moves into existing directories - #578
Open
Himanshuagrawal4 wants to merge 1 commit into
Open
Himanshuagrawal4 wants to merge 1 commit into
Himanshuagrawal4 wants to merge 1 commit into
Conversation
Refs fsspec#569 Assisted-by: OpenAI Codex
Himanshuagrawal4
marked this pull request as ready for review
November 18, 2026 19:22
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Explain which operation to use when the destination is already a directory. On
file://andmemory://paths, renaming a file into an existing directory can return the directory rather than the moved file. The guide recommendsmove_into()for that operation andmove()when the target is the new filename. This does not change rename behavior or the planned compatibility work.Type of Change
Testing
rename,move, andmove_intoagainst plain Windows paths,file://, andmemory://using temporary files. Checked whether the source stayed put, where it ended up, and which path the method returned.Checklist
Refs #569.
AI assistance: OpenAI Codex helped prepare the documentation and run the local checks.