Repository navigation
fix: support bytes paths in native filesystem operations - #86
Open
kushaldave002 wants to merge 1 commit into
Open
kushaldave002 wants to merge 1 commit into
kushaldave002 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
+ Coverage 94.30% 95.08% +0.77%
==========================================
Files 13 13
Lines 738 1017 +279
==========================================
+ Hits 696 967 +271
- Misses 42 50 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #84.
With
path_encoding=None, several native operations pass byte paths to string-only separators or shell quoting. This preserves byte paths in metadata and parent handling, skips byte-valued dot entries in listings, and uses SFTP copy and streamed MD5 for byte paths. Relative uploads also skip creating an empty parent directory.The README documents the supported native operations, the transfer cost of byte-path checksums, and the remaining string-path requirement in inherited fsspec traversal/bulk methods.
Verified seven regression cases fail before the fix. After the fix:
uv run pytest --cov-report=xml --cov=. --reruns 1 --reruns-delay 2: 113 passed, six existing deprecation warnings.uvx pre-commit run --all-files: Black, isort, mdformat, and codespell passed.