Skip to content

fix: support bytes paths in native filesystem operations - #86

Open
kushaldave002 wants to merge 1 commit into
fsspec:mainfrom
kushaldave002:fix-byte-path-operations
Open

kushaldave002 wants to merge 1 commit into
fsspec:mainfrom
kushaldave002:fix-byte-path-operations

Conversation

@kushaldave002

Copy link
Copy Markdown

Fixes #84.

With path_encoding=None, several native operations pass byte paths to string-only separators or shell quoting. This preserves byte paths in metadata and parent handling, skips byte-valued dot entries in listings, and uses SFTP copy and streamed MD5 for byte paths. Relative uploads also skip creating an empty parent directory.

The README documents the supported native operations, the transfer cost of byte-path checksums, and the remaining string-path requirement in inherited fsspec traversal/bulk methods.

Verified seven regression cases fail before the fix. After the fix:

  • uv run pytest --cov-report=xml --cov=. --reruns 1 --reruns-delay 2: 113 passed, six existing deprecation warnings.
  • uvx pre-commit run --all-files: Black, isort, mdformat, and codespell passed.
  • Confirmed the SFTP copy API is available in the minimum supported AsyncSSH 2.11.0.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.08%. Comparing base (15aac74) to head (bc250f2).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   94.30%   95.08%   +0.77%     
==========================================
  Files          13       13              
  Lines         738     1017     +279     
==========================================
+ Hits          696      967     +271     
- Misses         42       50       +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bytes paths (path_encoding=None) only work in some methods

2 participants