Skip to content

fix: synchronous rmdir() fails silently - #85

Open
Rainyyyyyyy111 wants to merge 1 commit into
fsspec:mainfrom
Rainyyyyyyy111:oss-contributor/issue-38
Open

Rainyyyyyyy111 wants to merge 1 commit into
fsspec:mainfrom
Rainyyyyyyy111:oss-contributor/issue-38

Conversation

@Rainyyyyyyy111

Copy link
Copy Markdown

Fixes #38

SSHFileSystem inherits the no-op rmdir because _rmdir lacks a synchronous wrapper.

Wrap _rmdir for synchronous directory removal; cover plain, SSH and SFTP paths, missing directories and recursive removal.

Validation: the regression fails on the original code and passes with the fix; the configured test suite and checks pass.

AI-assisted with Codex; independently tested by OSS Contributor.

OSS-Contributor-Artifact: 679ddc0a35296cf762b24d17c4b87bdaba100df8da492fcf82efcb739ccd2836
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.30%. Comparing base (15aac74) to head (c8a8662).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main      #85    +/-   ##
========================================
  Coverage   94.30%   94.30%            
========================================
  Files          13       14     +1     
  Lines         738      949   +211     
========================================
+ Hits          696      895   +199     
- Misses         42       54    +12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

synchronous rmdir() fails silently

2 participants