Repository navigation
feat: modernize the player and recover from stream dropouts #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ahmaxed
wants to merge
5
commits into
main
Choose a base branch
from
feat/modernize-player
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5495c1c
build: move from Create React App to Vite, React 19 and Node 24
ahmaxed d74381c
fix: rewrite the player as hooks and make playback recover on its own
ahmaxed 06c3308
test: add unit tests and move Cypress to v16 with recovery tests
ahmaxed 1b26a5f
ci: run lint, unit tests, build and Cypress on current runners
ahmaxed c3d6eb1
fix: restore screen reader only text and match the old history icon
ahmaxed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,67 +1,54 @@ | ||
| name: Coderadio-client ci | ||
| name: CI | ||
|
|
||
| on: [push, pull_request] | ||
| on: | ||
| push: | ||
| branches: [main] | ||
| pull_request: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| lint: | ||
| name: Lint | ||
| runs-on: ubuntu-20.04 | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
|
|
||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout Source Files | ||
| uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2 | ||
|
|
||
| - name: Install modules | ||
| run: npm ci | ||
|
|
||
| - name: Run ESLint | ||
| run: npm run lint | ||
|
|
||
| cypress-run: | ||
| name: Cypress Test | ||
| # Netlify deploys onto Ubuntu 20.04, so we should test on that os: | ||
| runs-on: ubuntu-20.04 | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| - uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0 | ||
| with: | ||
| node-version-file: .nvmrc | ||
| cache: npm | ||
| - run: npm ci | ||
| - run: npm run lint | ||
|
|
||
| test: | ||
| name: Unit tests and build | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| - uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0 | ||
| with: | ||
| node-version-file: .nvmrc | ||
| cache: npm | ||
| - run: npm ci | ||
| - run: npm test | ||
| - run: npm run build | ||
|
|
||
| e2e: | ||
| name: Cypress (${{ matrix.browser }}) | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| browsers: [chrome, firefox] | ||
| node-version: [20.x] | ||
| browser: [chrome, firefox] | ||
| steps: | ||
| - name: Set Action Environment Variables | ||
| run: | | ||
| echo "CYPRESS_RECORD_KEY=${{ secrets.CYPRESS_RECORD_KEY }}" >> $GITHUB_ENV | ||
| echo "GITHUB_TOKEN=${{ secrets.GITHUB_TOKEN }}" >> $GITHUB_ENV | ||
| echo "CYPRESS_INSTALL_BINARY=6.0.0" >> $GITHUB_ENV | ||
|
|
||
| - name: Checkout | ||
| uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2 | ||
|
|
||
| - name: Cypress run | ||
| uses: cypress-io/github-action@v2 | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| - uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0 | ||
| with: | ||
| node-version-file: .nvmrc | ||
| - uses: cypress-io/github-action@18016a55674bd02cabf197de5762a1710cb5577c # v7.4.9 | ||
| with: | ||
| browser: ${{ matrix.browsers }} | ||
| browser: ${{ matrix.browser }} | ||
| build: npm run build | ||
| start: npm start | ||
| start: npm run preview | ||
| wait-on: http://localhost:3001 | ||
| wait-on-timeout: 1200 | ||
|
|
||
| unit-test: | ||
| name: Unit Test | ||
| runs-on: ubuntu-20.04 | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
|
|
||
| steps: | ||
| - name: Checkout Source Files | ||
| uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2 | ||
|
|
||
| - name: Install modules | ||
| run: npm ci | ||
|
|
||
| - name: Run tests | ||
| run: npm test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1 @@ | ||
| CYPRESS_INSTALL_BINARY=0 | ||
| engine-strict=true | ||
| enable-pre-post-scripts=true | ||
| package-manager-strict=false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 20.19.0 | ||
| 24 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| dist | ||
| package-lock.json | ||
| cypress/videos | ||
| cypress/screenshots |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,9 @@ | ||
| { | ||
| "endOfLine":"auto", | ||
| "endOfLine": "auto", | ||
| "semi": true, | ||
| "singleQuote": true, | ||
| "jsxSingleQuote": true, | ||
| "tabWidth": 2, | ||
| "trailingComma": "none", | ||
| "arrowParens": "avoid" | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| import { defineConfig } from 'cypress'; | ||
|
|
||
| export default defineConfig({ | ||
| e2e: { | ||
| baseUrl: 'http://localhost:3001', | ||
| supportFile: false, | ||
| video: false | ||
| } | ||
| }); |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might as well bump node to v26 here.