Repository navigation
fix: keep the published SDK readable by Kotlin 2.1 apps - #98
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dhruwang
approved these changes
Oct 19, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What & why
Was:
mainbuilds the SDK with Kotlin 2.4.20 (Dependabot #69, #78) and carries that into what it publishes: Kotlin 2.4 metadata, akotlin-stdlib2.4.20 dependency andkotlinx-serialization-json1.11.0 (Kotlin 2.3). An app on Kotlin 2.2 or older cannot compile against it. The last release, 2.2.0, was built with Kotlin 2.1. Nothing with this has shipped.Now: the compiler stays at 2.4.20 (AGP 9 and the Kotlin Gradle plugin advisory need it) but writes Kotlin 2.1 output, and CI fails if the published POM or class metadata goes above that baseline.
Changes
android/build.gradle.kts:languageVersionandapiVersion2.1, andcoreLibrariesVersion2.1.0 (the stdlib the POM declares).gradle/libs.versions.toml:kotlinx-serialization-json1.11.0 → 1.8.0.scripts/check-kotlin-baseline.pyand.github/workflows/kotlin-baseline.yml: build the POM and AAR the way publishing does, then fail if a Kotlin library in the POM or the metadata stamped on the classes is above Kotlin 2.1.Where to look
scripts/check-kotlin-baseline.py: the two ceilings at the topandroid/build.gradle.kts: thekotlin {}blockCoverage
setAppearancecompiles on Kotlin 2.1 through all three entry points (Builder.setAppearance,Formbricks.setAppearancewith the enum and with a string)qa_modalsurvey renders dark (builder), light, then dark (enum calls)main's buildmain, passes herelanguageVersion/apiVersionfails the class stamps,coreLibrariesVersionfails the POM stdlib, serialization back to 1.11.0 fails the POMRerun:
./gradlew :android:generatePomFileForMavenPublication :android:bundleReleaseAar --no-configuration-cache && python3 scripts/check-kotlin-baseline.py android/build/publications/maven/pom-default.xml android/build/outputs/aar/android-release.aarOpen gaps
databinding-ktx9.4.1 comes from AGP and is stamped 2.2, so the practical floor is Kotlin 2.1.