Repository navigation
End CFF hflex and hflex1 curves at the starting y - #438
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #437
hflexandhflex1charstring operators left the second curve at the raised y instead of returning to the starting y (Adobe TN #5177). Every point after such a flex was shifted by the flex's dy, giving steps or misplaced contours.hflex:c5yis now the starting y (dx5, -dy2), so the curve ends where it started.hflex1:dy6is implied, soc6yis the starting y.Regression test in
test/issues.js: PlayfairDisplay glyph 33 has a contour ending in an hflex-style curve, which must end at its starting point.Validation:
npx mocha test/issues.json the build without the fix: 1 failing (0 !== 1); with the fix: 48 passing.npm test: 770 passing, 7 pending.npm run format:check: clean.