Repository navigation
Upgrade flutter candidate and DCM version - #10048
kenzieschmoll wants to merge 12 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request cleans up redundant argument values across several DevTools packages. Specifically, it simplifies CrossAxisAlignment.values.toList(growable: true) to toList(), replaces Expanded(child: SizedBox()) with Spacer(), and updates numerous Completer.complete(null) calls to complete(). It also updates the changelog for devtools_app_shared and updates package dependencies in pubspec.lock. I have no feedback to provide.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request cleans up redundant null arguments in Completer.complete() calls, replaces an empty Expanded box with Spacer, and introduces custom SIMD formatting in variable_factory.dart to ensure consistent display representation across VM and web platforms. Feedback suggests using lane.toUnsigned(32) instead of bitwise AND to guarantee correct unsigned 32-bit hex formatting on the web, and adjusting the CHANGELOG entry to use past tense and end with a period.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…ory.dart Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Only forward dt's stdin to child processes when stdin is a terminal. On CI, stdin is /dev/null. package:io's sharedStdIn reads it to EOF, which makes dart:io close fd 0. With the posix_spawn-based macOS process implementation (Dart SDK commit 0171629a5478), spawning children after fd 0 is closed breaks their stdio, so nested dt invocations (e.g. `dt pub-get` under `dt generate-code`) hang forever waiting on a child that already exited. This hung every macOS CI job with the new Flutter candidate. See dart-lang/sdk#64744.
srawlins
left a comment
srawlins
left a comment
There was a problem hiding this comment.
New ProcessManager stuff LGTM
DDS only collects event history for a stream if the connected VM service
supports it. The web debug service has no Timer stream, so with the new
DDS implementation in the Dart SDK, `getStreamHistory('Timer')` fails with
an invalid params error. `DdsExtension.onEventWithHistory` calls
`getStreamHistory` when first listened to, and that error cannot be handled
by listeners, which broke the Logging view (and the live connection
integration test) for web apps.
Check whether history is collected for a stream before using the DDS history
stream, and fall back to the regular stream if not.
Upgrade flutter version and DCM version and fix associated lints and warnings.