Skip to content

[flutter_webrtc] Apply audio processing constraints - #1218

Merged
seungsoo47 merged 1 commit into
flutter-tizen:mainfrom
seungsoo47:upstream-plugins-webrtc-audio-processing
Nov 18, 2026
Merged

seungsoo47 merged 1 commit into
flutter-tizen:mainfrom
seungsoo47:upstream-plugins-webrtc-audio-processing

Conversation

@seungsoo47

Copy link
Copy Markdown
Contributor

The echoCancellation, noiseSuppression and autoGainControl audio constraints were ignored: the audio source was always created with the default RTCAudioOptions and the track settings always reported true.

Map the W3C and goog-prefixed keys (flat, mandatory and optional forms) to RTCAudioOptions passed to CreateAudioSource, and report the applied values in the track settings.

Ported from upstream flutter-webrtc:
flutter-webrtc/flutter-webrtc#2068 (2c0951fea704d52d1c66d6f17b092a9dfdbf6835, flutter-webrtc 1.5.0)

The echoCancellation, noiseSuppression and autoGainControl audio
constraints were ignored: the audio source was always created with the
default RTCAudioOptions and the track settings always reported true.

Map the W3C and goog-prefixed keys (flat, mandatory and optional forms)
to RTCAudioOptions passed to CreateAudioSource, and report the applied
values in the track settings.

Ported from upstream flutter-webrtc:
flutter-webrtc/flutter-webrtc#2068
(2c0951fea704d52d1c66d6f17b092a9dfdbf6835, flutter-webrtc 1.5.0)
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T01:18:58.502202Z 00e69ef PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 00e69ef0ae

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@seungsoo47
seungsoo47 merged commit 5fb4c9c into flutter-tizen:main Nov 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants