Repository navigation
fix(customers): leave phone out of the customer profile update - #75
Merged
Merged
Conversation
Sending the account's own number back, as #73 did, is accepted, and Fleet-Ops mirrors it onto the linked user. In the contract run that user is shared with the seeded customer, so the seeded number stopped matching anyone and Request Customer Login SMS answered 400 "No customer with this phone number found." The update now changes name and email only. Changing a phone has its own verified flow (`phone_code`), still documented in the params. Removes created_customer_phone, which nothing reads now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #73.
Update Authenticated Customerno longer sendsphone.#73 made the request send the account's own number back. The API accepts that and Fleet-Ops mirrors the number onto the linked user. In the contract run,
Create a Customermakes its customer under the seeded customer's email (ci-customer@fleetbase.local), so the two share a user record. The mirrored random number replaced the seeded+15555550123, andRequest Customer Login SMS, which asks for that number, then answered 400No customer with this phone number found.nameandemailonly.phone_codestays documented in the params. Changing a number has its own verified flow, which this collection doesn't cover yet.created_customer_phoneis removed; nothing reads it now.Related Issue
Found by fleetbase/fleetops#426's contract run: run 43413319115. It had 1 failure in 388 assertions, and this was it.
Update Authenticated Customeritself passed in that run.Type of Change
Validation
Not run before opening: the contract itself. Contract runs read
postmanmain, so fleetops#426's contract is re-run after this merges, and that's the check.Documentation Impact
No request is added or removed, so fleetbase-php's
contract-lock.jsonand the fleetbase.io catalog are unaffected. The generated reference shows the update body withoutphoneon its next regeneration.