Repository navigation
test: bring fixtures up to date and cover the order config work on release/v0.7.0 - #427
Merged
Merged
Conversation
CustomerController eager-loads driverRating on customer orders since the passenger rides work, so the hand-built SQLite schema needs the table.
…ies column The adhoc strategy moved from order_configs.adhoc_strategy into the policies JSON in the order config policies refactor.
roncodes
changed the title
…emplates and endpoints The order config policies, triggers and templates work on release/v0.7.0 had no PHP CI run, so these lines were never measured: - the cancel, open chat and set meta actions, and notify driver with nothing to say - OrderCustomFields validate and apply - OrderUpdate's FCM and APN messages - the internal capabilities and create from template endpoints - the OrderConfig resource's custom fields - template registration and unknown template keys - Condition with collections and single values - custom field and payment method refusals on customer and API order creation, and dispatch refused by the config
roncodes
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v0.7.0 #427 +/- ##
====================================================
Coverage 100.00% 100.00%
- Complexity 13947 14689 +742
====================================================
Files 642 676 +34
Lines 50099 51282 +1183
====================================================
+ Hits 50099 51282 +1183
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP CI on #426 fails on two test files whose hand-built SQLite schemas predate changes on
release/v0.7.0. Nobody saw them because #426's PHP CI couldn't install until core-api 2.0.0 reached Packagist.CustomerControllerHelperSeamsTest:no such table: driver_ratings.CustomerControllerhas eager-loadeddriverRatingsince feat(dispatch): adhoc dispatch strategies, safe accept, ride flow and rider features #424. This adds the table with the columnsAdhocDispatchAndOrderConfigTestuses.OrderControllerNearbyFiltersTest:no such column: oc.policies. The order config's adhoc strategy moved fromorder_configs.adhoc_strategyintopoliciesJSON. The fixture now createspoliciesinstead.Locally all 517 test files pass against core-api 2.0.0. Before this change, these two failed.
Coverage. With the tests passing, the 100% line gate failed at 99.85%: 71 statements from the 9 November order config commits, which had never had a PHP CI run. The third commit adds tests for them, with no changes under
server/src:OrderUpdate::toFcm/toApnare run only up to core'sPushNotification, because the harness has no push credentials.