Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Reload the webhook server's TLS key pair when the certificate or key file changes on disk.
What this PR does / why we need it
WebhookServer.Start()loaded the key pair once and pinned it intls.Config.Certificates, so a certificate renewed in place (for example by cert-manager) was never served until the process restarted.The server now uses
tls.Config.GetCertificatebacked by a smallcertReloader. On each handshake it stats the cert and key files and reloads the pair when either mtime changed. If the new files fail to load (for example a half-written renewal), it logs a warning and keeps serving the previous pair. The initial load inStart()still fails fast. No new dependencies.Test_ServerReloadsRenewedCertificatestarts the server, overwrites the pair with a second one, and checks the leaf received viatls.Dial. It fails on main (serial = 1, want 2) and passes with this change.Closes #487
Special notes for your reviewer
The check is a
statper handshake rather than a file watcher, which keeps the change dependency-free and also covers Kubernetes secret volume updates (symlink swaps change the resolved file's mtime).