Repository navigation
fix(egress): fall back to IPv4 when the IPv6 path hangs (Happy Eyeballs) - #849
Merged
Merged
Conversation
…target (fclairamb/solidping-business#69) Under an enforcing egress guard, a dual-stack target whose IPv6 path drops SYNs looked down: DialContextWith (internal/egress/egress.go) dialed the pinned IPs one after the other, each with the 30 s dial timeout, so the IPv4 address was never tried within a probe's budget. It now dials them Happy-Eyeballs style like net.Dialer (happyeyeballs.go): the first family in order, the other raced in after FallbackDelay (300 ms default), first connection wins, the loser is closed. TestEnforcingDialFallsBackToIPv4WhenIPv6Hangs fails before the fix (v6 error after the probe budget) and passes after. Closes fclairamb/solidping-business#69 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fclairamb
added
autopilot
frozen
fclairamb
added a commit
that referenced
this pull request
Nov 12, 2026
…ack family (#852) Stacked on #848: merge it first. ## What changed - HTTP and Prometheus checks now return `warning` (rolled up as degraded) when a dual-stack target only answered on its fallback family, e.g. IPv6 unreachable but IPv4 up (answers the "which family failed" part of the issue, the IPv4 fallback itself shipped in #849). The result carries `output.ip_fallback` and the dashboard shows it. Pinned-family checks never warn. ## Decided by autopilot - Spec fclairamb/solidping-business#69 follow-up, Q1: warn only when the first family failed or was still pending 1 s after its start (recommended answer). - Q2: no separate v4/v6 sub-probes (recommended answer). ## Notes - With the 1 s threshold and the 300 ms race, a silently dropped v6 SYN with instant v4 will not warn; tune `FamilyFallbackThreshold` if wanted. - An HTTP check on `localhost` can now warn when `::1` is refused but `127.0.0.1` answers. - Batch gate: build, lint, Go tests, e2e typecheck/lint green; Playwright not run locally (left to CI). Closes fclairamb/solidping-business#69 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #848: merge it first.
Races IPv6 and IPv4 in the enforcing egress dialer (second family starts after 300 ms or on first failure), so dual-stack targets with a lossy IPv6 path no longer time out.
Not done (needs a spec): degraded status when only one family fails, reporting the answering family, v4/v6 sub-probes.
Closes fclairamb/solidping-business#69