[luke-hill]

I found this out by investigation that actually this would fail for a specific valid NI number (One that is known to be valid, but this system would detect it as invalid)

Original work / motivation from #3032

Motivation / Background

Fixed a bug whereby you cannot generate a valid NI number

Additional information

Checklist

Before submitting the PR make sure the following are checked:

• This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
• Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
• Tests are added or updated if you fix a bug, refactor something, or add a feature.
• Tests and Rubocop are passing before submitting your proposed changes.

If you're proposing a new generator or locale:

• Double-check the existing generators documentation to make sure the new generator you want to add doesn't already exist.
• You've reviewed and followed the Contributing guidelines.

[luke-hill]

@stefanjcollier @stefannibrasil minor item to review. Should be an easy merge and fix

[jremes-foss]

@luke-hill

The branch is out of date with the base branch.

Please update the branch. Once done, I will review this.

Thank you.

[luke-hill]

Hi @jremes-foss this should be RtM now

[thdaraujo]

thank you!

[thdaraujo]

tests are broken

[jremes-foss]

Looks like it's an issue in the test itself.

2181 tests, 279235 assertions, 1 failures, 0 errors

===============================================================================
Failure: test_en_gb_id_number_valid(TestEnGbLocale):
  </^[A-CEGHJ-PR-TW-Z][A-CEGHJ-NPR-TW-Z][0-9]{6}[A-DFM]$/> was expected to be =~
  <"TO039034C">.
/home/runner/work/faker/faker/test/test_en_gb_locale.rb:77:in 'TestEnGbLocale#test_en_gb_id_number_valid'
     74:     id_code = Faker::IdNumber.valid
     75: 
     76:     assert_equal(9, id_code.length)
  => 77:     assert_match(/^[A-CEGHJ-PR-TW-Z][A-CEGHJ-NPR-TW-Z][0-9]{6}[A-DFM]$/, id_code)
     78:   end
     79: 
     80:   def test_en_gb_id_number_invalid
===============================================================================

The regex check fails. Why? Has something changed?

[jremes-foss]

Also, another rebase is needed.

[luke-hill]

That failure suggests TO as a starting prefix is valid.

I cannot comment on this. But checking AI e.t.c. they suggest O cannot be the second letter. So the bug is already present in the code. Even without my changes. You can see the O was already present.

EDIT1: I am happy to do this bugfix as well. If the OP will accept the change
EDIT2: I can see in the output it suggests that F and M are valid suffixes. According to here this is also wrong

[luke-hill]

FYI I haven't fixed the test code stipulating the F and M are permitted as I'm using the interactive editor.