Repository navigation
Conversation
ENH: hide/unhide based on tagse
Since envmodules 5.7.0, the module command cannot be used directly with commands like prepend-path outwith a modulefile. We also can't rely on $itrp as this interpretor has not yet been set. We instead use the cmdModuleResurface which wraps the module command, and lets us use sub-commands this early in the module processing.
Author
|
Sorry, I moved to quickly through the Github options, didn't realise this would open the PR against the upstream project. Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling envmodules 5.7.0 we get the following errors:
An analysis shows that this is caused by calling
module prepend-path ...within thesiteconfig.tcl, which is no longer allowed in version 5.7.0.This PR fixes this, while maintain the old behaviour for older versions of envmodules.