Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Issue #121 poses the problem of rebuild on changes for WSL when using
notify::RecommendedWatcher.This PR aims to solve it by auto switching the watcher to
notify::PollWatcher(as recommended in notify's documentation) when the watched path is detected to be a network FS. The check for network FS is only done for Windows builds in the implementation (mainly to only aim WSL).The old
Watchertype has been redefined to anenum AnyDebouncertype which has two debouncersNativeDebouncerandNetworkFSDebouncer, that use eithernotify::RecommendedWatcherornotify::PollWatcher(and call their ownwatchmethod).I also reduced error logging verbosity for watch errors on ignored paths (which happens a lot with symlinks that go out of the watched dir). If this is not wanted I will revert it.
This is my first PR on a Rust project, please feel free give feedback on things that I should change.
Thanks for reading, have a nice day!