Skip to content

MCP: report adc_comp with an older embeddedci SDK too #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wardviaene merged 1 commit into from
Oct 31, 2026
Merged

MCP: report adc_comp with an older embeddedci SDK too #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/embeddedci-mcp/src/embeddedci_mcp/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1385,14 +1385,15 @@ async def adc_read(source: AdcSource = "ext", range: AdcRangeArg = None) -> m.Ad


def _calibration_result(c: Any) -> m.CalibrationResult:
comp = getattr(c, "adc_comp", None) # an older embeddedci SDK has no such field
dac = {k: (None if v is None else m.DacLineResult(a=v.a, b=v.b, offset=v.offset, gain_ppm=v.gain_ppm))
for k, v in (c.dac or {}).items()}
return m.CalibrationResult(source=c.source, calibrated=c.calibrated, offset=c.offset, a=c.a, b=c.b,
count=c.count, span=c.span, samples=c.samples, dac=dac,
adc_gain_ppm=dict(c.adc_gain_ppm or {}), dmm=c.dmm, measured=c.measured,
adc_low_gain_ppm=c.adc_low_gain_ppm,
adc_comp=None if c.adc_comp is None else {
"hf_dc_gain": c.adc_comp.hf_dc_gain, "c_top_pf": c.adc_comp.c_top_pf},
adc_comp=None if comp is None else {
"hf_dc_gain": comp.hf_dc_gain, "c_top_pf": comp.c_top_pf},
zero_count=c.zero_count)


Expand Down