Repository navigation
e2e: tests for the quad DAC on analog v3r2 - #52
Merged
Merged
Conversation
On the quad DAC the 4-20 mA output has its own channel, so the 5 V loopback cannot read it. Tests that read it that way skip there and need the J9 fixture, and a new test checks that a current leaves the 5 V output alone. Accept board revision v3r2 in the strap and MCP checks, route the deep replay test, and probe the control loop sweep more than once. Green on a v3-r2 (SDK 113/0, MCP 9/0, OpenHTF 2/0). Not yet run on a board with the DAC mux. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wardviaene
enabled auto-merge
October 31, 2026 02:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the quad DAC the 4-20 mA output has its own channel, so the 5 V loopback cannot read it. Tests that read it that way skip there and need the J9 fixture, and a new test checks that a current leaves the 5 V output alone. Accept board revision v3r2 in the strap and MCP checks, route the deep replay test, and probe the control loop sweep more than once. Green on a v3-r2 (SDK 113/0, MCP 9/0, OpenHTF 2/0). Not yet run on a board with the DAC mux.
🤖 Generated with Claude Code