Repository navigation
Proper subtyping btween fun(n) and (none...->term) - #16033
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15829
A function line with no positive arrows means "every function of this arity". This clause says such a line is never empty, whatever the negatives are. So when equal? computes fun(1) and not (none -> term), the result has no positives and one negative, gets reported as non-empty, and equal? returns false.
Arrows that are built explicitly don't hit this, because they always have positives. That's why (int -> atom) ≤ (none -> term) is already true, while fun(1) ≤ (none -> term) is false.
Fix
Treat the empty-positives case as one explicit top arrow and reuse the existing algorithm:
Assisted by: Claude Opus 5.5