Skip to content

ci: Remove the comment trigger for snapshot releases - #508

Merged
eddeee888 merged 1 commit into
masterfrom
ci/snapshot-dispatch-only
Nov 20, 2026
Merged

eddeee888 merged 1 commit into
masterfrom
ci/snapshot-dispatch-only

Conversation

@eddeee888

Copy link
Copy Markdown
Owner

Why

  • ci: Publish snapshots from workflow_dispatch instead of issue_comment #507 kept the PR comment command by relaying it to a workflow_dispatch run. Snapshots will now be started manually, so the relay is unnecessary indirection.
  • workflow_dispatch can only be started by users with write access. That replaces the OWNER check, and the event is one npm accepts for trusted publishing.

What

  • Removes the issue_comment trigger and the release-snapshot-trigger job, along with its actions: write permission, the khan/pull-request-comment-trigger action and the owner check.
  • release-snapshot is unchanged. It runs on workflow_dispatch with a pr input and still comments the snapshot versions, or the failure, on that PR.

To publish a snapshot, use Actions → Release → Run workflow with the PR number, or run gh workflow run release.yml -f pr=<n>.

Verification

  • YAML parses and Prettier passes
  • After merge: dispatch with pr=505. It should publish the snapshot and comment on the PR.

Generated by Claude Code

Snapshots are started manually with workflow_dispatch, so the comment relay
job, its actions: write permission and the third-party comment-trigger action
are no longer needed. GitHub's write-access check on workflow_dispatch
replaces the OWNER check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NyYayCPaAA2eaLr74FHJHN
@changeset-bot

changeset-bot Bot commented Nov 20, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a2e2dc8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eddeee888
eddeee888 merged commit ae249be into master Nov 20, 2026
19 checks passed
@eddeee888
eddeee888 deleted the ci/snapshot-dispatch-only branch November 20, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants