Repository navigation
ci: Remove the comment trigger for snapshot releases - #508
Merged
Merged
Conversation
Snapshots are started manually with workflow_dispatch, so the comment relay job, its actions: write permission and the third-party comment-trigger action are no longer needed. GitHub's write-access check on workflow_dispatch replaces the OWNER check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NyYayCPaAA2eaLr74FHJHN
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
workflow_dispatchrun. Snapshots will now be started manually, so the relay is unnecessary indirection.workflow_dispatchcan only be started by users with write access. That replaces theOWNERcheck, and the event is one npm accepts for trusted publishing.What
issue_commenttrigger and therelease-snapshot-triggerjob, along with itsactions: writepermission, thekhan/pull-request-comment-triggeraction and the owner check.release-snapshotis unchanged. It runs onworkflow_dispatchwith aprinput and still comments the snapshot versions, or the failure, on that PR.To publish a snapshot, use Actions → Release → Run workflow with the PR number, or run
gh workflow run release.yml -f pr=<n>.Verification
pr=505. It should publish the snapshot and comment on the PR.Generated by Claude Code