Repository navigation
feat: preheat and delete all the platforms of the image by default - #698
Merged
Merged
Conversation
gaius-qi
requested review from
BraveY,
CooooolFrog,
EvanCley and
xujihui1985
November 10, 2026 09:42
CormickKneey
previously approved these changes
Nov 10, 2026
CormickKneey
enabled auto-merge (squash)
November 10, 2026 09:47
gaius-qi
force-pushed
the
feature/preheat
branch
from
November 10, 2026 11:32
d4aca58 to
600d9a1
Compare
CormickKneey
previously approved these changes
Nov 10, 2026
gaius-qi
force-pushed
the
feature/preheat
branch
from
November 10, 2026 12:12
600d9a1 to
ceef32f
Compare
…tform Delete the image by the manifest url and the platform, the same as `PreheatImageRequest` and `StatImageRequest`, and take all the platforms of the image if the platform is not specified in any of them: - `DeleteImageRequest` takes the `url` of the image manifest and an optional `platform`, and deletes all the platforms of the image if the platform is not specified, the same as deleting an image name releases all its platforms in containerd. - `PreheatImageRequest` and `StatImageRequest` preheat and stat all the platforms of the image if the platform is not specified. The manager jobs do not use these requests, so their default platform is unchanged. - `common.v2.Image` in `Download` takes the `reference` and the optional `platform` of the image that the task belongs to, and the task belongs to all the platforms of the image if the platform is not specified. - Remove the image from `PreheatImageRequest`, because the scheduler already has the manifest url, and the platform of each preheated manifest. Regenerate the Go, Rust and Python bindings and bump the version to 2.3.10. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Gaius <gaius.qi@gmail.com>
CormickKneey
previously approved these changes
Nov 10, 2026
gaius-qi
force-pushed
the
feature/preheat
branch
from
November 10, 2026 12:20
ceef32f to
60895ef
Compare
hhhhsdxxxx
approved these changes
Nov 10, 2026
hyy0322
approved these changes
Nov 10, 2026
CormickKneey
approved these changes
Nov 10, 2026
This was referenced Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Delete all the platforms of the image if the platform of the image is empty in
DeleteImageRequest, the same as deleting an image name releases all its platforms in containerd, and allow the empty platform incommon.v2.Image.Preheat all the platforms of the image if the platform is not specified in
PreheatImageRequest. The platform of the image in the request is ignored, because the platform of each preheated manifest is recorded by the peers. The manager preheat jobs do not use this request, so their default platform is unchanged.Regenerate the Go and Rust bindings and bump the version to 2.3.10.
Related Issue
Motivation and Context