[bidi47]

• removed php 8.2, add php 8.6
• updated versions in workflows
• added docs for upcoming major release
• fixed issues, bugs in codebase, updated tests
• updated dependencies
  • removed laminas-servicemanager
• updated changelog, readme, security files
• updated phpstan to 8

[alexmerlin]

backwardCompatibilityCheck should be reverted to true

[alexmerlin]

Function spl_object_hash() is deprecated since 8.6, consider using spl_object_id() instead

See if we can replace spl_object_hash with spl_object_id

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (6.0@80bc692). Learn more about missing BASE report.

Additional details and impacted files

@@          Coverage Diff           @@
##             6.0      #65   +/-   ##
======================================
  Coverage       ?   88.80%           
  Complexity     ?       46           
======================================
  Files          ?        7           
  Lines          ?      125           
  Branches       ?        0           
======================================
  Hits           ?      111           
  Misses         ?       14           
  Partials       ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bidi47]

backwardCompatibilityCheck should be reverted to true

reverted back to true

Function spl_object_hash() is deprecated since 8.6, consider using spl_object_id() instead

See if we can replace spl_object_hash with spl_object_id

spl_object_hash is used in the doctrine and laminas dependencies
i tried updating the main packages in composer.json, but the usage is still present
or did you mean something else?

[alexmerlin]

spl_object_hash is used in the doctrine and laminas dependencies i tried updating the main packages in composer.json, but the usage is still present or did you mean something else?

No, I meant the deprecations from the CI actions:
https://github.com/dotkernel/dot-annotated-services/actions/runs/41623842376/job/125876192260?pr=65

[alexmerlin]

With the two tests I requested below we should cover the two open items mentioned in the Codecov report.

@arhimede Also, we should add a docs/book/v5/overview.md page, just to cover the gap between the versions 4 and 6. It should have a short note explaining why v5 is not documented.

[arhimede]

With the two tests I requested below we should cover the two open items mentioned in the Codecov report.

@arhimede Also, we should add a docs/book/v5/overview.md page, just to cover the gap between the versions 4 and 6. It should have a short note explaining why v5 is not documented.

Ok, make a V5 folder with explanations , one page only , in the PHP 6 style. mention attributes(dot-dependency-injection) and annotation ( v4 and v6)

2. create a 6.0 branch

[bidi47]

Ok, make a V5 folder with explanations , one page only , in the PHP 6 style. mention attributes(dot-dependency-injection) and annotation ( v4 and v6)

2. create a 6.0 branch

I created the page, updated the readme, and added several new tests.

The open item is the 6.0 branch. Is it ok to create it in the github UI from the upgrade source?

[alexmerlin]

The open item is the 6.0 branch. Is it ok to create it in the github UI from the upgrade source?

Home page -> Branches -> New branch button:

• Set New branch name to 6.0
• Keep Source as 4.0
• Click the Create new branch button

Then edit this PR by changing the destination from 4.0 to the new 6.0 branch.

[bidi47]

Then edit this PR by changing the destination from 4.0 to the new 6.0 branch.

Done.
Now branch 6.0 should be marked default and protected.

[arhimede]

check if we can remove the dependecy to laminas-servicemanager and replace it with direct psr/container

like here : https://github.com/dotkernel/dot-dependency-injection/blob/98a69c50af711cfe091506f766c5dbe9f39b2a65/composer.json#L29

[bidi47]

@alexmerlin can you please take a look at the latest commit from this PR? (cf438bc)
it's an attempt to remove laminas/laminas-servicemanager from composer.json, similar to dot-dependency-injection

[alexmerlin]

@alexmerlin can you please take a look at the latest commit from this PR? (cf438bc) it's an attempt to remove laminas/laminas-servicemanager from composer.json, similar to dot-dependency-injection

Looks good! 👍
And the CI is much greener. ✅