Repository navigation
Reduce time to BWAPI connection readiness - #1
Merged
Merged
Conversation
| Path library = bundledLibrary(resource, binary); | ||
| if (library == null && !Boolean.getBoolean("jna.nounpack") | ||
| && !"false".equalsIgnoreCase(System.getProperty("jbwapi.nativeCache"))) { | ||
| Path base = Paths.get(System.getProperty("jna.tmpdir", System.getProperty("java.io.tmpdir"))); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce work before the first BWAPI connection attempt: connect before creating frame buffers, metrics, and the bot wrapper, and bind only the Windows mapping functions the client uses.
mvn packagealso produces one distribution ZIP containing the existing JAR and architecture-named Windows DLLs directly beside it. The DLLs come from the finished JAR, so the packaged versions match. Licenses stay inside the JAR. No native-path flags or directory setup are needed.The loader selects the running JVM's architecture and verifies the adjacent DLL against the embedded copy. Missing or stale DLLs fall back to a private, verified cache; unavailable caches fall back to ordinary JNA extraction. Explicit JNA loading settings take precedence. JAR-only deployments and other supported platforms continue to work.
The packaging change uses one Maven ZIP task and removes the separate assembly descriptor. The test heap is 768 MB to support Java 8 x86. Connection retry behavior is unchanged.
Validation:
Full PurpleWave startup measured from process launch to first BWAPI lookup improved from a 475.1 ms median to 119.1 ms (five samples per version, Java 8 x86, warm filesystem caches). This is a measurement on one machine, not a startup guarantee.