Skip to content

test: accept prflx for direct connections in candidate type checks - #602

Merged
devopvoid merged 1 commit into
mainfrom
fix/stats-candidate-flake
Nov 20, 2026
Merged

devopvoid merged 1 commit into
mainfrom
fix/stats-candidate-flake

Conversation

@devopvoid

Copy link
Copy Markdown
Owner

Description

PeerTests.statsAfterConnecting and CallCheckTests.connectsToTestPeer now accept host or prflx as the local candidate type of a direct connection.

Motivation and Context

On a machine with a bridge, such as Docker's, the answer to a connectivity check can name another local address than the one the check was sent from. WebRTC then takes that address as a peer-reflexive local candidate, and the pair that uses it is sometimes selected. Both are direct connections, but the test expected host and failed about one run in three on such machines.

Type of Change

  • Tests (test)

Affected Modules

  • webrtc (Java API)

On a host with a bridge, such as Docker's, the answer to a check can name another local address, which WebRTC takes as a peer-reflexive local candidate. statsAfterConnecting failed about one run in three that way.
@devopvoid
devopvoid merged commit afc6e46 into main Nov 20, 2026
24 checks passed
@devopvoid
devopvoid deleted the fix/stats-candidate-flake branch November 20, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant