Repository navigation
test: accept prflx for direct connections in candidate type checks - #602
Merged
Merged
Conversation
On a host with a bridge, such as Docker's, the answer to a check can name another local address, which WebRTC takes as a peer-reflexive local candidate. statsAfterConnecting failed about one run in three that way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PeerTests.statsAfterConnectingandCallCheckTests.connectsToTestPeernow accepthostorprflxas the local candidate type of a direct connection.Motivation and Context
On a machine with a bridge, such as Docker's, the answer to a connectivity check can name another local address than the one the check was sent from. WebRTC then takes that address as a peer-reflexive local candidate, and the pair that uses it is sometimes selected. Both are direct connections, but the test expected
hostand failed about one run in three on such machines.Type of Change
test)Affected Modules
webrtc(Java API)