Repository navigation
feat: check camera, microphone and network before a call - #585
Merged
Merged
Conversation
WebRtc.checkCall measures whether a video track delivers frames that are not all black, whether an audio track delivers audio that is neither silent nor clipped, and whether a connection to a real test peer comes up, and names the problems it finds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
WebRtc.checkCall(CallCheck), a self-test for "am I ready for the call?": whether a video track delivers frames that are not all black, whether an audio track delivers audio that is neither silent nor clipped, and whether a connection to a real test peer comes up (withrelayOnly, through TURN). The result names the problems with their reasons, plus the measurements behind them.A microphone is sent to a pair of internal peers that drop every encoded frame, since WebRTC records only while it sends; nothing is played back.