Repository navigation
Conversation
A KeyProvider in dev.onvoid.webrtc.e2ee encrypts and decrypts encoded frames as RFC 9605 SFrame: participant keys with generations and rotation, a key ID per sent stream, replay protection, defined handling of unknown keys and failed frames, and codec layouts for VP8, VP9, AV1 and audio. PeerOptions, Whip and Whep take it as e2ee(keys). Transforms can keep their frames from encoded-frame observers; the native router enforces it, and MediaRecorder refuses such tracks unless the key provider allows plaintext recording. The guide specifies the frame format, and a WebCrypto implementation for browsers is published with the docs and tested against Java.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 39831195 | Triggered | Generic High Entropy Secret | 86642ea | webrtc/src/test/resources/dev/onvoid/webrtc/e2ee/rfc9605-test-vectors.txt | View secret |
| 39831193 | Triggered | Generic High Entropy Secret | 86642ea | webrtc/src/test/resources/dev/onvoid/webrtc/e2ee/rfc9605-test-vectors.txt | View secret |
| 39831194 | Triggered | Generic High Entropy Secret | 86642ea | webrtc/src/test/resources/dev/onvoid/webrtc/e2ee/rfc9605-test-vectors.txt | View secret |
| 39831195 | Triggered | Generic High Entropy Secret | 86642ea | webrtc/src/test/resources/dev/onvoid/webrtc/e2ee/rfc9605-test-vectors.txt | View secret |
| 39831194 | Triggered | Generic High Entropy Secret | 86642ea | webrtc/src/test/resources/dev/onvoid/webrtc/e2ee/rfc9605-test-vectors.txt | View secret |
| 39831194 | Triggered | Generic High Entropy Secret | 86642ea | webrtc/src/test/resources/dev/onvoid/webrtc/e2ee/rfc9605-test-vectors.txt | View secret |
| 39831195 | Triggered | Generic High Entropy Secret | 86642ea | webrtc/src/test/resources/dev/onvoid/webrtc/e2ee/rfc9605-test-vectors.txt | View secret |
| 39831195 | Triggered | Generic High Entropy Secret | 86642ea | webrtc/src/test/resources/dev/onvoid/webrtc/e2ee/rfc9605-test-vectors.txt | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
# Conflicts: # webrtc/src/main/java/module-info.java
A peer with e2ee(keys) applied no codec preference, so macOS negotiated H.264, whose frames end-to-end encryption drops. Such a peer now offers and answers only VP8, VP9 and AV1 video, and videoCodecs() that names none of them fails. KeyProvider.supportsCodec() tells which codecs can be encrypted. The call tests accept replayed frames, which retransmissions produce on loaded machines, and print the stats when other frames are dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
dev.onvoid.webrtc.e2ee: aKeyProviderwhose transforms encrypt and decrypt encoded frames as SFrame (RFC 9605), with key IDs, rotation, per-stream key contexts, replay protection and defined handling of unknown keys and failed frames. VP8, VP9, AV1 and audio are covered; H.264/H.265 are refused.PeerOptions,WhipandWheptake it ase2ee(keys).MediaRecorderrefuses encrypted tracks unless the key provider allows plaintext recording.