Repository navigation
feat: add system audio capture for desktop sharing - #572
Merged
Merged
Conversation
Fix PulseAudio capture timestamps (enable timing updates, date fragments of one poll contiguously), tolerate packet jitter of one chunk before treating a gap as a pause, and reject pushAudio on SystemAudioSource from threads other than the capture worker.
Now that a factory sends device-captured and pushed audio side by side, the guide and javadoc send the microphone from the same factory instead of a workaround, and a test sends both on one connection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #571.
Adds
SystemAudioSource, aCustomAudioSourcethat captures what the system plays on its default output, as 16-bit 48 kHz stereo, to send beside a screen track:start()/stop()run the capture on a worker thread of its own; failures stop recording and are reported throughgetFailure(). With #571 the microphone is sent from the same factory and connection. Includes a guide, an example, lifecycle tests with fake backends, and an opt-in integration test (-Dtest.systemAudio=true).