Repository navigation
feat: feed device-captured audio to senders through its track - #570
Merged
Merged
Conversation
createAudioSource() now returns a native DeviceAudioSource. The audio device module's proxy runs the recorded audio through the factory's AudioProcessing and hands it to these sources' sinks, the senders among them, instead of to WebRTC's transport, which fed every send stream. Local sinks on a microphone track now receive the processed audio.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createAudioSource()now returns a nativeDeviceAudioSource. The audio device module's proxy runs recorded audio through the factory'sAudioProcessingand hands it to these sources' sinks, the senders among them, instead of to WebRTC's transport, which fed it into every send stream of the factory.AudioProcessingitself, so recorded and playout audio reach the same instance and echo cancellation keeps working.AudioSendStream::SendAudioData, which both paths reach.Adds a test-only
ToneAudioDeviceModulethat records a tone, andDeviceAudioSendTests.