Repository navigation
docs(landing): translate /docs/installation into Korean - #892
Open
Restitutor1008 wants to merge 1 commit into
Open
Restitutor1008 wants to merge 1 commit into
Restitutor1008 wants to merge 1 commit into
Conversation
Add page.ko.mdx for /docs/installation, register it in src/i18n/pages.ts, and add language alternates to the English page metadata. Refs dev-five-git#870 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XKr1b8ZfeaoBrHc1WTodFK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #870
What
page.ko.mdxfor/docs/installation(Korean translation)./docs/installationinsrc/i18n/pages.ts, following the/docs/overviewentry.alternates.languages(en / ko / x-default) to the Englishpage.mdxmetadata, matching the overview example. English prose is unchanged.Why
Part of the Korean docs translation (#584), building on #881.
Notes on the translation
// no extract cssis translated.How I verified
Ran locally on macOS against the #881 branch, before it was merged. I then rebased onto current
main(no conflicts; the diff is still the same 3 files) but have not re-run the checks below on the rebased branch.bun install,bun run build(root): passedbun run build(apps/landing, includesnode script.js): passedtsc --noEmit -p apps/landing/tsconfig.json: passeddist/client/ko/docs/installation.html:lang="ko"https://devup-ui.com/ko/docs/installation/docs/installationis unchanged (lang="en").node e2e/serve-static.mjs 3099) and checked/ko/docs/installationand/docs/installationin the browser on desktop and mobile widths: headings, prose, all code blocks, the three example links, and the "Edit this page" link (points topage.ko.mdx) look correct.bun run lint(cargo fmt --check, cargo clippy, ESLint): passed, no warnings or errors.bun devbun devinapps/landingstarts, but every page fails to render in dev mode, including the untouched English/docs/overview([plugin:vite:oxc] PARSE_ERRORonoverview/page.mdx) and/ko/docs/overview. Vite also warns thatnext-intl'sNextIntlClientProvideris "inconsistently optimized". Since this reproduces on pages this PR doesn't touch, it seems to come from the dev setup rather than this translation. This was observed on the #881 branch before rebasing, so it may already be different on currentmain. The production build renders all of these pages correctly.Known test failures
bunx playwright test e2e/landing-i18n.spec.ts: 4 passed, 2 failed.English remains the default and Korean overview is translated(line 3)Korean routes render translated or English content without JavaScript(line 76)Both tests use
/docs/installationas the example of an untranslated page and expect/ko/docs/installationto redirect to the English URL. With this translation, the page now renders in Korean instead, so these assertions fail as a direct result of the translation, not because of a rendering problem. I didn't change the tests to keep this PR scoped to the translation. Happy to update them (e.g. switch the fallback example to another untranslated page) if you'd like that included here.AI usage
The first draft of the translation was generated with Claude, then reviewed and edited by me.
🤖 Generated with Claude Code
https://claude.ai/code/session_01XKr1b8ZfeaoBrHc1WTodFK