Skip to content

docs(landing): translate /docs/installation into Korean - #892

Open
Restitutor1008 wants to merge 1 commit into
dev-five-git:mainfrom
Restitutor1008:docs/ko-installation
Open

Restitutor1008 wants to merge 1 commit into
dev-five-git:mainfrom
Restitutor1008:docs/ko-installation

Conversation

@Restitutor1008

Copy link
Copy Markdown

Closes #870

What

  • Add page.ko.mdx for /docs/installation (Korean translation).
  • Register /docs/installation in src/i18n/pages.ts, following the /docs/overview entry.
  • Add alternates.languages (en / ko / x-default) to the English page.mdx metadata, matching the overview example. English prose is unchanged.

Why

Part of the Korean docs translation (#584), building on #881.

Notes on the translation

  • Code blocks, package names, and URLs are unchanged. Only the explanatory comment // no extract css is translated.
  • Used "Rsbuild" consistently (the English body uses lowercase "rsbuild" in places).
  • Rendered "you can install / you can use" as plain instructions (e.g. "설치합니다") to avoid an unnatural literal translation.

How I verified

Ran locally on macOS against the #881 branch, before it was merged. I then rebased onto current main (no conflicts; the diff is still the same 3 files) but have not re-run the checks below on the rebased branch.

  • bun install, bun run build (root): passed
  • bun run build (apps/landing, includes node script.js): passed
  • tsc --noEmit -p apps/landing/tsconfig.json: passed
  • Checked the built output dist/client/ko/docs/installation.html:
    • renders the Korean page (no redirect to English), lang="ko"
    • canonical is https://devup-ui.com/ko/docs/installation
    • hreflang alternates for en / ko / x-default are present
    • all headings and the translated comment appear; no English section headings remain
  • English /docs/installation is unchanged (lang="en").
  • Served the static build (node e2e/serve-static.mjs 3099) and checked /ko/docs/installation and /docs/installation in the browser on desktop and mobile widths: headings, prose, all code blocks, the three example links, and the "Edit this page" link (points to page.ko.mdx) look correct.
  • bun run lint (cargo fmt --check, cargo clippy, ESLint): passed, no warnings or errors.

bun dev

bun dev in apps/landing starts, but every page fails to render in dev mode, including the untouched English /docs/overview ([plugin:vite:oxc] PARSE_ERROR on overview/page.mdx) and /ko/docs/overview. Vite also warns that next-intl's NextIntlClientProvider is "inconsistently optimized". Since this reproduces on pages this PR doesn't touch, it seems to come from the dev setup rather than this translation. This was observed on the #881 branch before rebasing, so it may already be different on current main. The production build renders all of these pages correctly.

Known test failures

bunx playwright test e2e/landing-i18n.spec.ts: 4 passed, 2 failed.

  • English remains the default and Korean overview is translated (line 3)
  • Korean routes render translated or English content without JavaScript (line 76)

Both tests use /docs/installation as the example of an untranslated page and expect /ko/docs/installation to redirect to the English URL. With this translation, the page now renders in Korean instead, so these assertions fail as a direct result of the translation, not because of a rendering problem. I didn't change the tests to keep this PR scoped to the translation. Happy to update them (e.g. switch the fallback example to another untranslated page) if you'd like that included here.

AI usage

The first draft of the translation was generated with Claude, then reviewed and edited by me.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XKr1b8ZfeaoBrHc1WTodFK

Add page.ko.mdx for /docs/installation, register it in
src/i18n/pages.ts, and add language alternates to the English
page metadata.

Refs dev-five-git#870

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XKr1b8ZfeaoBrHc1WTodFK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ko] Translate /docs/installation into Korean

1 participant