Repository navigation
fix(git): reject local client certificates without empty TLS path overrides - #14
Merged
Merged
Conversation
ellmos-multi-bot
commented
Nov 2, 2026
ellmos-multi-bot
left a comment
ellmos-multi-bot
left a comment
Collaborator
Author
There was a problem hiding this comment.
Independent Codex reviewer instance review-core-skills-codex@ASUS-GEI (not the author instance). Exact head 9d98706. Full four-file diff and adjacent Git transport invariants reviewed: PASS, no blocking findings. Independently executed full suite: 320 passed, 2 skipped. Additional real-Git negative tests passed for generic/scoped/includeIf client certificates, malformed configuration, and stripping injected certificate/config environment. TLS verification retained. No authenticated push exercised. Local evidence: reports/2026-11-02/independent-core14-review.md in the private operator instance. This COMMENT records independent technical acceptance and is not an account-level APPROVE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git branch publication currently fails with
fatal: refusing to work with credential missing host field: Git receives emptyhttp.sslCert=/http.sslKey=overrides from the hardened transport.Reject effective local client-certificate settings (including URL scopes and includes) before pushing, and stop emitting empty certificate paths. System/global config and certificate environment overrides remain excluded; token identity, AskPass isolation, HTTPS verification, redirects, credential/header/cookie resets, branch prefix and exact remote readback remain enforced. Probe errors fail closed and expose no config values.
Validation: full source suite 320 passed / 2 skipped; 55 targeted tests passed again against the built wheel. Read-only public Git probe failed with the original flags and succeeds with the correction. Built wheel SHA256 eab816fa08d050a44c136a149896a9e67253e0cd062960e3f6bb8252036cf521. A task-isolated wheel runtime published this branch through Core preview/apply as ellmos-multi-bot; the permanent companion installation is unchanged. Independent security review and CI are required before merge or permanent rollout.