Repository navigation
Read the given names Sultana and Sultan as names outside a title phrase (#752 phase 2j, #853) - #903
Merged
Merged
Conversation
…se (#752 phase 2j, #853) The fifth and sixth title batches of phase 2j, combined by Derek. `sultana` and `sultan` gain dated given readings, so each is a title only inside a title phrase, unreported. `Sultana Begum`, `Sultan Khan`, `Mr Sultan Khan` and `Khan, Sultan` read the given name, where 1.4.0 through 2.6.0 read a title; `His Majesty Sultan Hassanal Bolkiah` and `Sultan of Brunei` keep it. The cost, the class accepted for `king`: a sultan written with the bare title reads it as the given name. Measured against master 6ba78d0: PSC 111 fixed, 1 broken (a title-box Sultan); ctgov 41, FEC 21, tse 1; jrc 9 and nepal 6 now alike, 0 apart. `sultana` alone: PSC 28 fixed, 0 broken, every move a fix. AGENTS.md records #901's lesson: a word whose reading moves may be its class's worked example. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fifth and sixth title batches of phase 2j (#752), combined at Derek's call.
sultanaandsultangain datedgivenreadings (sultan's on its tr.toml entry), so each is a title only inside a title phrase.What changes
Sultana BegumSultana, no given nameSultanaSultan KhanSultan, no given nameSultanMr Sultan Khan(#853)Mr SultanMr, givenSultanKhan, SultanSultanSultanHis Majesty Sultan Hassanal Bolkiah,Sultan of BruneiSultan Hassanal BolkiahSultan, givenHassanalSultan(the accepted cost)No listed phrase holds either word, so nothing is reported. The other sites read as for
king: before a family comma, ending the name, after a full name and a comma, and past a second comma. The Ottoman writing after the name was already a name word (Hurrem Sultan).The cost (rules/H9, Accepted)
A sultan written with the bare title reads it as the given name, the class accepted for
king. Sized at the review's prompting, the cost is larger thanking's:Sultan/Sultana. By my reading about 40 are rulers (mostly Ottoman sultans and today's Gulf and Malay rulers), about 80 are people named Sultan, and 13 are mosques and other places.kinghad about 10 monarchs there.Sultanin the title box before a name, the batch's one broken record.Measured
Against master
6ba78d0d(after #901), py3.11, every local corpus with--base; counts and token shapes only.sultanaaloneAA, SULTANA)The 6 changed are each still wrong for another reason, mostly a two-word surname box. Six of sultana's ctgov names were
Aa Sultana, CRED, which master read with the credential as the given name:Nasreen Sultana, MBBSnow gives givenNasreen, familySultana, suffixMBBS, reportedsuffix-or-name. The committed corpora, CLDR and GND don't move.Found by the review, not fixed here
Constants().titles.remove(word)now raisesKeyErrorfor every word phase 2j moved out of the titles 2.6.0 listed:wing,mahdi,bard,buddha,siddha,gyani,king, and nowsultanandsultana. 2.6.0 accepted these removals. It's recorded in decisions/H9 and proposed as its own fix before 2.7.0 ships.sheikhis a style, soSheikh Sultan Khankeeps titleSheikh Sultanas master reads it. That's left forsheikh's batch.Docs
Mr Sultan Khanline is fixed.suffix-or-nameunder three orders.Checks
uv run pytestand--python 3.15: 27,075 passed each.-n0 -m serial, mypy, ruff,sphinx-build -b doctest.Refs #752, #348, #853
🤖 Generated with Claude Code