Skip to content

vromtool: store shared samples once - #176

Merged
dciabrin merged 2 commits into
dciabrin:masterfrom
dogruis:vromtool-share-identical-samples
Nov 4, 2026
Merged

dciabrin merged 2 commits into
dciabrin:masterfrom
dogruis:vromtool-share-identical-samples

Conversation

@dogruis

@dogruis dogruis commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

Closes #173. Samples with identical data now share one V-ROM location, and the output is unchanged when nothing is shared.

@dogruis
dogruis force-pushed the vromtool-share-identical-samples branch from f7d57b2 to 52e14de Compare October 31, 2026 15:53
@dciabrin

dciabrin commented Nov 1, 2026

Copy link
Copy Markdown
Owner

Unrelated issue on macOS, will fix that before merging this PR

@dciabrin

dciabrin commented Nov 1, 2026

Copy link
Copy Markdown
Owner

Filed issues #177 and #179, I'll fix them first.

@dciabrin

dciabrin commented Nov 2, 2026

Copy link
Copy Markdown
Owner

@dogruis can you rebase your PR to head? it should pickup a macOS 27 runner and get the CI passing.

@dogruis
dogruis force-pushed the vromtool-share-identical-samples branch from 52e14de to 1bcd3a5 Compare November 2, 2026 10:12
@dogruis
dogruis force-pushed the vromtool-share-identical-samples branch from 1bcd3a5 to 2119e77 Compare November 2, 2026 11:36
Comment thread tools/vromtool.py


def record_sample(sample, recorded_samples):
data_key = (type(sample), bytes(sample.data))

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bold :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's my middle name!

Comment thread tools/vromtool.py Resolved
Comment thread tools/vromtool.py Resolved
@dogruis
dogruis requested a review from dciabrin November 2, 2026 19:39
@dciabrin
dciabrin merged commit 7bafd51 into dciabrin:master Nov 4, 2026
3 checks passed
@dogruis
dogruis deleted the vromtool-share-identical-samples branch November 4, 2026 15:07
dciabrin pushed a commit that referenced this pull request Nov 4, 2026
Fix #174 and built on top of #176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vromtool duplicates a sample that several songs share

2 participants