Repository navigation
vromtool: store shared samples once - #176
Merged
dciabrin merged 2 commits intoNov 4, 2026
Merged
Conversation
dogruis
force-pushed
the
vromtool-share-identical-samples
branch
from
October 31, 2026 15:53
f7d57b2 to
52e14de
Compare
Owner
|
Unrelated issue on macOS, will fix that before merging this PR |
Owner
This was referenced Nov 1, 2026
Merged
Owner
|
@dogruis can you rebase your PR to head? it should pickup a macOS 27 runner and get the CI passing. |
dogruis
force-pushed
the
vromtool-share-identical-samples
branch
from
November 2, 2026 10:12
52e14de to
1bcd3a5
Compare
dogruis
force-pushed
the
vromtool-share-identical-samples
branch
from
November 2, 2026 11:36
1bcd3a5 to
2119e77
Compare
dciabrin
requested changes
Nov 2, 2026
|
|
||
|
|
||
| def record_sample(sample, recorded_samples): | ||
| data_key = (type(sample), bytes(sample.data)) |
Contributor
Author
There was a problem hiding this comment.
That's my middle name!
dciabrin
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #173. Samples with identical data now share one V-ROM location, and the output is unchanged when nothing is shared.