Repository navigation
Update admin config - #178
Merged
infeo merged 3 commits intoOct 29, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The documented permission check incorrectly flags a successful setup as a failure by forbidding the inherited (I) markers expected on config.properties after /reset.
1 open issue
What changed in this PR
Updates the desktop admin configuration documentation to reflect the Windows security checks introduced in cryptomator/cryptomator#4362.
Changes:
- Documents ownership, permission, and path requirements for loading admin configuration on Windows.
- Explains installer behavior and provides commands to secure and verify existing configuration files.
| File | Description |
|---|---|
docs/desktop/admin-config.mdx |
Adds Windows trust requirements and permission setup and verification instructions. |
Review effort: Balanced
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The permissions checklist and deployment-tool instruction incorrectly present installer defaults as enforced requirements, excluding valid configurations the verifier accepts.
1 open issue
1 resolved since last review
Review effort: Balanced
Updated admin-config documentation to clarify ownership and permissions requirements for deployment tools. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address changes made in cryptomator/cryptomator#4362