Skip to content

render: make the retained factory member protected in base classes - #193

Merged
igagis merged 1 commit into
mainfrom
ren_fac_prot
Nov 19, 2026
Merged

igagis merged 1 commit into
mainfrom
ren_fac_prot

Conversation

@igagis

@igagis igagis commented Nov 19, 2026

Copy link
Copy Markdown
Member

The concrete renderer objects (e.g. the Vulkan texture_2d, vertex_buffer, index_buffer and the shader classes) previously kept a redundant copy of the shared factory reference in a private ctx_ref member, because the factory member retained by the base classes (ruis::render::texture_2d, vertex_buffer, index_buffer and the shader base classes) was private.

Make those retained factory members protected so the derived classes can access them directly and drop the redundant ctx_ref members.

Follow-up to #192 (the factory extraction).

The concrete renderer objects (e.g. the Vulkan texture_2d, vertex_buffer,
index_buffer and the shader classes) previously kept a redundant copy of
the shared factory reference in a private ctx_ref member, because the
factory member retained by the base classes (ruis::render::texture_2d,
vertex_buffer, index_buffer and the shader base classes) was private.

Make those retained factory members protected so the derived classes can
access them directly and drop the redundant ctx_ref members.
@igagis
igagis merged commit 7662d76 into main Nov 19, 2026
0 of 50 checks passed
@igagis
igagis deleted the ren_fac_prot branch November 19, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant