Repository navigation
render: make the retained factory member protected in base classes - #193
Merged
Merged
Conversation
The concrete renderer objects (e.g. the Vulkan texture_2d, vertex_buffer, index_buffer and the shader classes) previously kept a redundant copy of the shared factory reference in a private ctx_ref member, because the factory member retained by the base classes (ruis::render::texture_2d, vertex_buffer, index_buffer and the shader base classes) was private. Make those retained factory members protected so the derived classes can access them directly and drop the redundant ctx_ref members.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The concrete renderer objects (e.g. the Vulkan texture_2d, vertex_buffer, index_buffer and the shader classes) previously kept a redundant copy of the shared factory reference in a private ctx_ref member, because the factory member retained by the base classes (ruis::render::texture_2d, vertex_buffer, index_buffer and the shader base classes) was private.
Make those retained factory members protected so the derived classes can access them directly and drop the redundant ctx_ref members.
Follow-up to #192 (the factory extraction).