Repository navigation
ci: add job timeouts and concurrency groups - #167
Merged
Merged
Conversation
Every job gets timeout-minutes: 10; the slowest recent job (publish) took at most 288 s, CI jobs at most 104 s. CI cancels superseded PR runs; publish keeps a per-ref group without cancelling. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
Review round 1Reviewer: Claude agent (Opus 5.5), fresh context, brief + diff only. Commit: 6572995. Verdict: approve (one minor item to fix). Checked: all 6 jobs in both workflow files have Findings:
|
A shared group keeps only one pending run, so a quick third push dropped CI for the middle commit. Drop the no-op publish group. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
Review round 1 response
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds run hygiene to both workflows.
timeout-minutes: 10on every job (5 inci.yml, 1 inpublish.yml).ci.yml: pull requests get a concurrency group per workflow and ref, and a new push cancels the superseded run. Each push tomaingets its own group (per SHA), so no commit onmainloses its run (a shared group keeps only one pending run).publish.yml: only the timeout; trigger, permissions and steps are unchanged.pushwas already limited tomain(the default branch); no change.Measured durations (why 10 minutes fits)
Last 15 finished
CIruns and last 8Publishruns (7 succeeded, 1 failed at 130 s), per job, max:Decisions
timeout-minutes: 10on every job"ci.yml(5 jobs),publish.yml(1 job)pushlimited to the default branch next topull_request"ci.ymlon.push.branches: [main]concurrencygroup per workflow and ref withcancel-in-progress: truefor PRs"ci.ymltop-levelconcurrencymain: grouped per SHA instead of per ref, so queued main runs are not droppedpublish.ymlStatus
🤖 Generated with Claude Code