Skip to content

Fix typo preventing all_communities from correctly managing site setting cache - #2178

Open
Oaphi wants to merge 1 commit into
developfrom
0valt/all_communities_caching
Open

Oaphi wants to merge 1 commit into
developfrom
0valt/all_communities_caching

Conversation

@Oaphi

@Oaphi Oaphi commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

It's supposed to be SiteSettings/, not SiteSetting/. Confirmed live

@Oaphi
Oaphi marked this pull request as ready for review November 17, 2026 20:01
@Oaphi
Oaphi requested review from ArtOfCode- and cellio November 17, 2026 20:01
@codecov

codecov Bot commented Nov 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.27%. Comparing base (25a58c0) to head (4648e3f).

Additional details and impacted files
Components Coverage Δ
controllers 78.15% <ø> (+0.03%) ⬆️
helpers 85.62% <ø> (ø)
jobs 79.93% <ø> (ø)
models 93.56% <100.00%> (ø)
tasks 61.11% <ø> (ø)
scripts ∅ <ø> (∅)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cellio cellio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't test locally; I'm relying on the test you did on the dev server (and the new test case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants