Skip to content

Fix incorrect max length in error message when site setting exceeds 255 - #2177

Merged
Oaphi merged 6 commits into
developfrom
trichoplax/fix-comment-thread-max-length-message-edge-case
Nov 15, 2026
Merged

Oaphi merged 6 commits into
developfrom
trichoplax/fix-comment-thread-max-length-message-edge-case

Conversation

@trichoplax

Copy link
Copy Markdown
Contributor

The site setting for maximum comment thread length is limited to 255, but there is an edge case where the error message when the length is exceeded could show a higher number while still being triggered at 255.

This change ensures the error message will show the same limit that is being applied, and will never show more than 255.

@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.27%. Comparing base (9602fd4) to head (7f96eda).

Additional details and impacted files
Components Coverage Δ
controllers 78.15% <ø> (+0.03%) ⬆️
helpers 85.62% <ø> (ø)
jobs 79.93% <ø> (ø)
models 93.56% <100.00%> (ø)
tasks 61.11% <ø> (ø)
scripts ∅ <ø> (∅)

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trichoplax
trichoplax force-pushed the trichoplax/fix-comment-thread-max-length-message-edge-case branch from ef9d390 to 6fa53d4 Compare November 13, 2026 19:16
Comment thread app/models/comment_thread.rb Resolved
Comment thread test/models/comment_thread_test.rb Resolved
Comment thread test/models/comment_thread_test.rb Resolved
Comment thread test/models/comment_thread_test.rb Resolved
@Oaphi
Oaphi merged commit 25a58c0 into develop Nov 15, 2026
14 checks passed
@Oaphi
Oaphi deleted the trichoplax/fix-comment-thread-max-length-message-edge-case branch November 15, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants