Repository navigation
Fix incorrect max length in error message when site setting exceeds 255 - #2177
Merged
Oaphi merged 6 commits intoNov 15, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
trichoplax
force-pushed
the
trichoplax/fix-comment-thread-max-length-message-edge-case
branch
from
November 13, 2026 19:16
ef9d390 to
6fa53d4
Compare
Oaphi
reviewed
Nov 13, 2026
Oaphi
requested changes
Nov 15, 2026
Oaphi
reviewed
Nov 15, 2026
Oaphi
approved these changes
Nov 15, 2026
Oaphi
deleted the
trichoplax/fix-comment-thread-max-length-message-edge-case
branch
November 15, 2026 19:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The site setting for maximum comment thread length is limited to 255, but there is an edge case where the error message when the length is exceeded could show a higher number while still being triggered at 255.
This change ensures the error message will show the same limit that is being applied, and will never show more than 255.