Repository navigation
Avoid making silent thread followers pingable (for privacy) - #2176
trichoplax wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Does the "notify for new comments" logic run through the |
Good question. In the CommentsController, both So I believe all the ways of causing a ping will now only regard a user as pingable if they are an editor of the post, or the author of the post, an answer, or a comment on the post. |
|
Sorry, I'm still confused. Will non-participant thread followers continue to receive notifications with this change? (Do we have a test case for that?) |
This shouldn't affect non-ping-mention notifications to thread followers, only whether thread followers are available to be directly pinged. To clarify: Here "pingable" means "can be @-mentioned", rather than "can be notified". It's asking who the comment author can choose to ping, rather than who the system can send notifications to.
Good catch. We do not as far as I can see (let me know if I've overlooked an existing one). I've added one now. |
|
Since it has caused confusion here, it might be worth renaming the existing |
I don't think we need to rename the function. The meaning of ping is clear; I just wanted to check that our code didn't bake in any assumptions about who gets notifications -- I could imagine a code path that calls |
By intention, only moderators have access to view the list of followers of a comment thread. However, including silent thread followers (those who have no interaction with the thread or post or answers other than following the thread) in the list of pingable users currently leaks this information to any user.
Since there is no reason to be able to ping a user who has no connection to the thread, this change removes silent thread followers from the list of pingable users.