Repository navigation
Conversation
Reversean
requested changes
Sep 21, 2026
akulistus
force-pushed
the
feat/setup-mcp
branch
from
October 14, 2026 15:40
6814c54 to
65c4e9f
Compare
Co-authored-by: Reversean <43142829+Reversean@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #678 +/- ##
==========================================
- Coverage 58.30% 52.13% -6.17%
==========================================
Files 19 64 +45
Lines 518 3063 +2545
Branches 95 729 +634
==========================================
+ Hits 302 1597 +1295
- Misses 216 1387 +1171
- Partials 0 79 +79 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Approval is blocked by an inconsistent committed lockfile and unresolved MCP authentication and integration-test gaps.
3 open issues
What changed in this PR
Adds initial Model Context Protocol (MCP) support to the Hawk API, including a test hello_world tool and an Express endpoint at /integration/mcp.
Changes:
- Adds MCP server and Node adapter dependencies.
- Implements the MCP server and
hello_worldtool. - Registers the MCP route during application startup.
- Updates package metadata and dependency lockfile.
This pull request requires changes.
| File | Summary |
|---|---|
yarn.lock |
Adds MCP-related dependency entries, but its resolved selectors do not match the MCP dependency ranges declared in package.json. |
src/integrations/mcp/mcp.ts |
Creates the MCP server and request handler; the server instance should be created per request to avoid shared transport state. |
src/integrations/mcp/index.ts |
Mounts the MCP handler on Express; authentication/authorization and integration coverage are still required. |
src/index.ts |
Registers the MCP route during application startup after database initialization. |
package.json |
Adds MCP dependencies and updates the package version; the declared dependency ranges require a regenerated lockfile. |
Review effort: Lite
Comment on lines
+46
to
+47
| "@modelcontextprotocol/node": "^2.1.2", | ||
| "@modelcontextprotocol/server": "^2.4.0", |
Comment on lines
+11
to
+14
| export function appendMCPRoutes(app: express.Application, factories: ContextFactories): void { | ||
| const handler = createMCPHandler(factories); | ||
|
|
||
| app.use('/integration/mcp', (req, res) => handler(req, res, req.body)); |
| export function appendMCPRoutes(app: express.Application, factories: ContextFactories): void { | ||
| const handler = createMCPHandler(factories); | ||
|
|
||
| app.use('/integration/mcp', (req, res) => handler(req, res, req.body)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setup MCP server integration